Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stub generator script filtering all "extern" strings #1048

Closed
jphickey opened this issue May 24, 2021 · 0 comments · Fixed by #1049 or #1058
Closed

Stub generator script filtering all "extern" strings #1048

jphickey opened this issue May 24, 2021 · 0 comments · Fixed by #1049 or #1058
Assignees
@jphickey
Labels
bug
Milestone
Caelum

Comments

@jphickey
Copy link
Contributor

Describe the bug
In order to parse the headers the "generate_stubs.pl" script needs to filter out "extern" keywords. Problem is, it is filtering the "extern" string even if it appears inside a larger string, not just the keywords.

To Reproduce
View the generated stub for "OS_TimeBaseCreate". The last parameter should be external_sync but it its appearing in the generated code as al_sync instead.

Expected behavior
Should appear in the generated code as external_sync, same as header.

Code snips

osal/src/ut-stubs/osapi-timebase-stubs.c

Line 41 in 1d183e9

int32 OS_TimeBaseCreate(osal_id_t *timebase_id, const char *timebase_name, OS_TimerSync_t al_sync)

System observed on:
Ubuntu

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this May 24, 2021
@jphickey jphickey added the bug label May 24, 2021
jphickey added a commit to jphickey/osal that referenced this issue May 24, 2021
@jphickey
Fix nasa#1048, filter only whole words for keyword match
d06680e 
In the stub generator script, filter only whole words
when ignoring keywords.  Do not match if the word appears
as a substring inside a larger word.
@jphickey jphickey mentioned this issue May 24, 2021
Merged
jphickey added a commit to jphickey/osal that referenced this issue May 25, 2021
@jphickey
Fix nasa#1048, also filter C++-style comments
e8add95 
Truncate input lines at C++-style comment markers, in case users/projects
allow this style of comment.
astrogeco added a commit that referenced this issue Jun 2, 2021
@astrogeco
Merge pull request #1049 from jphickey/fix-1048-extern-strings
d5d370a 
Fix #1048, filter only whole words for keyword match
@astrogeco astrogeco mentioned this issue Jun 2, 2021
Merged
pepepr08 pushed a commit to pepepr08/osal that referenced this issue Jun 9, 2021
@jphickey @pepepr08
Fix nasa#1048, filter only whole words for keyword match
d35ce9d 
In the stub generator script, filter only whole words
when ignoring keywords.  Do not match if the word appears
as a substring inside a larger word.
pepepr08 pushed a commit to pepepr08/osal that referenced this issue Jun 9, 2021
@jphickey @pepepr08
Fix nasa#1048, also filter C++-style comments
fd60cf4 
Truncate input lines at C++-style comment markers, in case users/projects
allow this style of comment.
@skliper skliper added this to the 6.0.0 milestone Sep 24, 2021
jphickey pushed a commit to jphickey/osal that referenced this issue Aug 10, 2022
@astrogeco
Merge pull request nasa#1048 from ArielSAdamsNASA/main
4d406db 
Fix nasa#1068, Create cFE Security Policy Markdown
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
bug
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper