Fix #1417, Fix #1418, Fix workflow bug and enforce updating of covera…

…ge minimums
nasa · Sep 23, 2023 · d449b9c · d449b9c
1 parent b5dd01c
commit d449b9c
Showing 1 changed file with 26 additions and 5 deletions.
diff --git a/.github/workflows/standalone-build.yml b/.github/workflows/standalone-build.yml
@@ -10,7 +10,7 @@ defaults:
 
 env:
   allowed_ncov_lines: 0
-  allowed_ncov_branches: 4
+  allowed_ncov_branches: 3
   allowed_ncov_functions: 0
 
 jobs:
@@ -34,7 +34,7 @@ jobs:
           path: source
 
       - name: Install Coverage Analysis Tools
-        if: ${{ matrix.build-type == 'Debug' && matrix.base-os == 'ubuntu-20.04' }}
+        if: ${{ matrix.build-type == 'Debug' }}
         run: sudo apt-get install -y lcov xsltproc && echo "run_lcov=TRUE" >> $GITHUB_ENV
 
       - name: Set up debug environment
@@ -89,23 +89,44 @@ jobs:
           binary-dir: build
 
       - name: Enforce coverage function minimum
-        if: ${{ always() && steps.stats.outputs.ncov_functions > env.allowed_ncov_functions }}
+        if: ${{ env.run_lcov == 'TRUE' && always() && steps.stats.outputs.ncov_functions > env.allowed_ncov_functions }}
         run: |
           echo "::error::Too many uncovered functions (${{ steps.stats.outputs.ncov_functions }})"
           /bin/false
 
       - name: Enforce coverage line minimum
-        if: ${{ always() && steps.stats.outputs.ncov_lines > env.allowed_ncov_lines }}
+        if: ${{ env.run_lcov == 'TRUE' && always() && steps.stats.outputs.ncov_lines > env.allowed_ncov_lines }}
         run: |
           echo "::error::Too many uncovered lines (${{ steps.stats.outputs.ncov_lines }})"
           /bin/false
 
       - name: Enforce coverage branch minimum
-        if: ${{ always() && steps.stats.outputs.ncov_branches > env.allowed_ncov_branches }}
+        if: ${{ env.run_lcov == 'TRUE' && always() && steps.stats.outputs.ncov_branches > env.allowed_ncov_branches }}
         run: |
           echo "::error::Too many uncovered branches (${{ steps.stats.outputs.ncov_branches }})"
           /bin/false
 
+      - name: Enforce keeping coverage function minimum up-to-date
+        if: ${{ env.run_lcov == 'TRUE' && always() && steps.stats.outputs.ncov_functions < env.allowed_ncov_functions }}
+        run: |
+          echo "::error::${{ steps.stats.outputs.ncov_functions }} uncovered function(s) reported, but ${{ env.allowed_ncov_functions }} are allowed."
+          echo "::error::Please update (lower) the allowed_ncov_functions variable to ${{ steps.stats.outputs.ncov_functions }} in order to match the new coverage level."
+          /bin/false
+
+      - name: Enforce keeping coverage line minimum up-to-date
+        if: ${{ env.run_lcov == 'TRUE' && always() && steps.stats.outputs.ncov_lines < env.allowed_ncov_lines }}
+        run: |
+          echo "::error::${{ steps.stats.outputs.ncov_lines }} uncovered line(s) reported, but ${{ env.allowed_ncov_lines }} are allwoed."
+          echo "::error::Please update (lower) the allowed_ncov_lines variable to ${{ steps.stats.outputs.ncov_lines }} in order to match the new coverage level."
+          /bin/false
+
+      - name: Enforce keeping coverage branch minimum up-to-date
+        if: ${{ env.run_lcov == 'TRUE' && always() && steps.stats.outputs.ncov_branches < env.allowed_ncov_branches }}
+        run: |
+          echo "::error::${{ steps.stats.outputs.ncov_branches }} uncovered branch(es) reported, but ${{ env.allowed_ncov_branches }} are allowed."
+          echo "::error::Please update (lower) the allowed_ncov_branches variable to ${{ steps.stats.outputs.ncov_branches }} in order to match the new coverage level."
+          /bin/false
+
       - name: Assemble Results
         if: ${{ always() }}
         run: |