Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #45 - null terminates src/dst filenames #46

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Fix #45 - null terminates src/dst filenames #46

merged 3 commits into from
Jul 1, 2020

Conversation

CDKnightNASA
Copy link
Contributor

Describe the contribution
Adds a null to the end of SrcFilename and DstFilename when using strncpy.

Contributor Info - All information REQUIRED for consideration of pull request
Christopher.D.Knight@nasa.gov

@CDKnightNASA CDKnightNASA self-assigned this Jun 5, 2020
@CDKnightNASA CDKnightNASA linked an issue Jun 5, 2020 that may be closed by this pull request
SrcFilename and DstFilename not ensured to be null-terminated #45
Closed
@astrogeco
Copy link
Contributor

@CDKnightNASA when do you want to discuss this with the CCB?

@CDKnightNASA
Copy link
Contributor Author

@CDKnightNASA when do you want to discuss this with the CCB?

today? :D

@CDKnightNASA CDKnightNASA marked this pull request as ready for review June 24, 2020 15:28
@astrogeco astrogeco added CCB-20200624 CCB:Approved Indicates code approval by CCB and removed CCB:Ready labels Jun 24, 2020
@astrogeco
Copy link
Contributor

CCB-20200624: APPROVED

@astrogeco astrogeco changed the base branch from master to integration-candidate July 1, 2020 13:50
@astrogeco astrogeco changed the title fix #45 - null terminates src/dst filenames Fix #45 - null terminates src/dst filenames Jul 1, 2020
@astrogeco astrogeco merged commit 685964d into nasa:integration-candidate Jul 1, 2020
@astrogeco astrogeco mentioned this pull request Jul 1, 2020
Merged
@skliper skliper added this to the 3.2.0 milestone Aug 21, 2020
@skliper skliper linked an issue Jan 26, 2021 that may be closed by this pull request
Input file Description/TableName without terminator causes segfault #43
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@CDKnightNASA CDKnightNASA

Labels
CCB:Approved Indicates code approval by CCB
Projects
None yet
Milestone
Bootes
3 participants
@CDKnightNASA @astrogeco @skliper