Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workflow branch restrictions, add duplicate check, fix format check name #83

Closed
astrogeco opened this issue Sep 10, 2021 · 1 comment · Fixed by #97
Closed

Remove workflow branch restrictions, add duplicate check, fix format check name #83

astrogeco opened this issue Sep 10, 2021 · 1 comment · Fixed by #97

Comments

@astrogeco
Copy link
Contributor

Describe the bug

The format check and static analysis workflows only run on pushes to main or on pull requests so community users will not get the alerts on their forks.

The CodeQL workflow may run on pull requests to branches other than main

To Reproduce
Fork repo, commit new branch: format check and static analysis workflows aren't triggered.

Expected behavior
All workflows run on fork branches, even those without pull requests.

Code snips

on:
push:
branches:
- main
pull_request:

on:
push:
branches:
- main
pull_request:

on:
push:
pull_request:
branches:
- main

System observed on:
GitHub

Additional context
Should also add check-for-duplicates job to workflows after relaing the branch requirement on the push trigger

Reporter Info
Full name and company/organization if applicable

astrogeco added a commit to astrogeco/elf2cfetbl that referenced this issue Sep 11, 2021
Enable format-check and static-analysis workflows to run on push to
arbitrary branches.

Enable CodeQL workflow to run on pull requests targeting arbitrary
branches.
@skliper skliper changed the title Workflows do not run on push to arbitrary branches Remove workflow branch restrictions, add duplicate check, fix format check name Oct 22, 2021
skliper added a commit to skliper/elf2cfetbl that referenced this issue Oct 22, 2021
@skliper skliper linked a pull request Feb 5, 2022 that will close this issue
@skliper
Copy link
Contributor

skliper commented Feb 5, 2022

Closed by #97

@skliper skliper closed this as completed Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants