Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moves interface definition to inc #133

Closed
chillfig opened this issue Dec 6, 2022 · 2 comments
Closed

Moves interface definition to inc #133

chillfig opened this issue Dec 6, 2022 · 2 comments
Assignees
@chillfig

Comments

@chillfig
Copy link

chillfig commented Dec 6, 2022

Is your feature request related to a problem? Please describe.
The interface definition files of all open source apps currently exist in the "src" directory.

Describe the solution you'd like
Create an "inc" dir to go with the "src" dir. Move the interface definitions into this location: "_msg.h", "_msgdefs.h", "_tbldefs.h", and "_events.h". Consider moving header files in both "platform_inc" and "mission_inc" to "inc"

Describe alternatives you've considered
Leaving as is.

Additional context
N/A

Requester Info
Justin Figueroa, Vantage Systems
@chillfig chillfig self-assigned this Dec 6, 2022
chillfig added a commit to chillfig/ci_lab that referenced this issue Dec 6, 2022
@chillfig
Fix nasa#133, Move interface definition files to inc
4e78c36
@chillfig chillfig mentioned this issue Dec 6, 2022
Closed
chillfig added a commit to chillfig/ci_lab that referenced this issue Dec 6, 2022
@chillfig
Fix nasa#133, Moves interface definition files to inc
ff211ce
@skliper
Copy link
Contributor

skliper commented Nov 14, 2023

@dzbaker - should this be closed? I think #147 and #148 covered it.

@dzbaker
Copy link
Collaborator

dzbaker commented Nov 15, 2023

Covered by #147, #148.

@dzbaker dzbaker closed this as completed Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chillfig chillfig

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #133, Moves interface definition files to inc chillfig/ci_lab
3 participants
@dzbaker @skliper @chillfig