Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #453, Cleanup shared static analysis workflow #454

Merged
merged 1 commit into from
Apr 18, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Apr 8, 2022

Checklist (Please check before submitting)

Describe the contribution

Removes leading . before directory list and removes matrix (slight re-ordering of tests)

Testing performed
CI

Expected behavior changes
Works on directory lists, just one flow where strict only runs on non-empty strict-dir-list

System(s) tested on
CI

Additional context
Impacts nasa/PSP#333 and nasa/CF#228

Code contributions
The cFS repository is provided to bundle the cFS Framework. It is utilized for bundling submodules, continuous integration testing, and version management and does not contain any software. Code contributions should be directed to the appropriate submodule.

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone Apr 8, 2022
@skliper skliper added the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 13, 2022
@astrogeco astrogeco removed the CCB:Ready Pull request is ready for discussion at the Configuration Control Board (CCB) label Apr 13, 2022
@astrogeco
Copy link
Contributor

Nit: Can we rename to "Fix #453, Cleanup shared static analysis workflow"

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Apr 13, 2022
@astrogeco
Copy link
Contributor

CCB:2022-04-13 APPROVED

@astrogeco astrogeco changed the title Fix #453, Shared static analysis workflow cleanup Fix #453, Cleanup shared static analysis workflow Apr 18, 2022
@astrogeco astrogeco merged commit f481f23 into nasa:main Apr 18, 2022
@skliper skliper deleted the fix453-static_analysis branch April 19, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB CCB:FastTrack dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static analysis workflow matrix and strict directory handling not working as intended
2 participants