Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update LGTM build to OMIT_DEPRECATED #72

Closed
skliper opened this issue Apr 24, 2020 · 0 comments · Fixed by #73
Closed

Update LGTM build to OMIT_DEPRECATED #72

skliper opened this issue Apr 24, 2020 · 0 comments · Fixed by #73
Labels
enhancement good first issue Good for newcomers

Comments

@skliper
Copy link
Contributor

skliper commented Apr 24, 2020

Is your feature request related to a problem? Please describe.
Deprecated elements included in analysis

Describe the solution you'd like
Remove deprecated elements from analysis

Describe alternatives you've considered
None.

Additional context
Will address some of the open LGTM issues.

Requester Info
Jacob Hageman - NASA/GSFC
skliper added a commit to skliper/cFS that referenced this issue Apr 27, 2020
@skliper
Fix nasa#72, LGTM now OMIT_DEPRECATED build
edc8b95
@skliper skliper mentioned this issue Apr 27, 2020
Merged
astrogeco added a commit that referenced this issue May 8, 2020
@astrogeco
Merge pull request #73 from skliper/fix72-lgtm-omit-deprecated
a8a6be1 
Fix #72,  LGTM build now omits deprecated code
chillfig pushed a commit to chillfig/cFS that referenced this issue Mar 17, 2022
@jphickey
Fix nasa#72, correct allocation size for CFDP PDU
eddca6d 
The call to CFE_SB_AllocateMessageBuffer needs to take into account
the size of the extra SB header, not just the CF_MAX_PDU_SIZE.
chillfig pushed a commit to chillfig/cFS that referenced this issue Mar 17, 2022
@astrogeco
Merge pull request nasa#74 from jphickey/fix-72-alloc-size
c5bdbd3 
Fix nasa#72, correct allocation size for CFDP PDU
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #72, LGTM build now omits deprecated code skliper/cFS
1 participant
@skliper