Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide mechanism to use different header definitions, same payload definition #103

Closed
skliper opened this issue Jun 9, 2020 · 1 comment · Fixed by #108 or #109
Closed

Provide mechanism to use different header definitions, same payload definition #103

skliper opened this issue Jun 9, 2020 · 1 comment · Fixed by #108 or #109
Assignees
@lbleier-GSFC
Labels
enhancement New feature or request
Milestone
Bootes

Comments

@skliper
Copy link
Contributor

skliper commented Jun 9, 2020

Is your feature request related to a problem? Please describe.
Multiple header formats are not easily supported in current implementation of the GUI.

Describe the solution you'd like
Make it easier (for example cFS version 1 or version 2 selection should be easy).

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added the enhancement New feature or request label Jun 9, 2020
@lbleier-GSFC
Copy link
Contributor

lbleier-GSFC commented Jun 16, 2020 •
edited
Loading

It would seem that resolving this also involves #61. I can try to implement cmdUtil functionality in python

@lbleier-GSFC lbleier-GSFC mentioned this issue Jun 16, 2020
Closed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - custom header mechanism
7754c9f 
Updated UI and backend to support custom header sizes.
Change only impacts tlm currently
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - custom header mechanism
09261e5 
Fix for rebase merge error
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
WIP: Enhancement nasa#103 - Implemented native cmdUtil
a0d1872 
Native cmdUtil has only subset of full cmdUtil functionality
Also implemented updates to GUI and backend to support custom
byte offsets in tlm and cmd
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
WIP: Enhancement nasa#103 - updates to miniCmdUtil
8ad565c
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
WIP: Enhancement nasa#103 - updates to miniCmdUtil
6d3f7ed
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
WIP: Enhancement nasa#103 - updates to miniCmdUtil and other files
9d233eb
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - updates to allow user to select header version
2a8911f 
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
@lbleier-GSFC lbleier-GSFC mentioned this issue Jun 29, 2020
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Squashed commit of the following:
adf31d8 
commit 2a8911f
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Fri Jun 26 17:34:54 2020 -0400

    Enhancement nasa#103 - updates to allow user to select header version

    Updates GUI and backend to allow user to select
    header version offsets, or custom byte offsets

commit 9d233eb
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Thu Jun 25 17:12:31 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil and other files

commit 6d3f7ed
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Wed Jun 24 13:53:51 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit 8ad565c
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Wed Jun 24 10:56:45 2020 -0400

    WIP: Enhancement nasa#103 - updates to miniCmdUtil

commit a0d1872
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Tue Jun 23 15:39:25 2020 -0400

    WIP: Enhancement nasa#103 - Implemented native cmdUtil

    Native cmdUtil has only subset of full cmdUtil functionality
    Also implemented updates to GUI and backend to support custom
    byte offsets in tlm and cmd

commit 09261e5
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Tue Jun 16 13:27:26 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Fix for rebase merge error

commit 7754c9f
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Tue Jun 16 12:38:33 2020 -0400

    Enhancement nasa#103 - custom header mechanism

    Updated UI and backend to support custom header sizes.
    Change only impacts tlm currently

commit 821f06c
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Mon Jun 1 09:57:02 2020 -0400

    Feature nasa#98 - Refactor UI to table widgets

    Removed unnecessary file

commit b0bd3fa
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Mon Jun 1 09:06:45 2020 -0400

    Feature nasa#98 - Refactor UI to use table widgets

    Backend updated accordingly. Other various tweaks/fixes as needed

commit fb0ccb6
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Wed May 27 16:23:40 2020 -0400

    Fix nasa#46 Recommended lgtm python issues

    Problems shown in this issue were fixed in nasa#72 as part of
    updates/refactoring. Other lgtm issues addressed here.
    Problems in auto-generated .py files not addressed.
    Auto-generated .py files renamed with Ui_ prefix.
    The lgtm.yml file must be updated to exclude these
    See nasa/cFS#92

commit b3d8039
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Wed May 20 07:54:39 2020 -0400

    Fix nasa#88 - Modify GroundSystem to use JSON files generated by CCDD

    Also includes further updates and refinements to overall UI

commit 26486cb
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Thu May 14 11:37:11 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Further edits based on CCB feedback, and other fixes as necessary

commit 876a39d
Author: Leor Bleier <Leor.Z.Bleier@nasa.gov>
Date:   Mon May 11 17:08:21 2020 -0400

    Fix nasa#72 - Upgrade PyQt4 to PyQt5

    Includes code cleanup/refactoring. Also fixes nasa#71
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - updates to allow user to select header version
8d3f8be 
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - updates to allow user to select header version
1a3b6dc 
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
@lbleier-GSFC lbleier-GSFC linked a pull request Jun 29, 2020 that will close this issue
Resolves #103 Custom header mechanism #108
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - removed a debug line and commented-out code
20fce30
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - slight fixes to cleanly catch exceptions
c2bd8f2
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - updates to allow user to select header version
449511e 
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jun 29, 2020
@lbleier-GSFC
Enhancement nasa#103 - further corrections and cleanup
e37501f 
Also removed the shareddata.py file; no longer needed
at this time
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jul 6, 2020
@lbleier-GSFC
Enhancement nasa#103 - updates to allow user to select header version
b2d7ee8 
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jul 6, 2020
@lbleier-GSFC
Enhancement nasa#103 - updates to allow user to select header version
b017500 
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jul 6, 2020
@lbleier-GSFC
Enhancement nasa#103 - further corrections and cleanup
fb58248 
Also removed the shareddata.py file; no longer needed
at this time
astrogeco added a commit that referenced this issue Jul 6, 2020
@astrogeco
Merge pull request #108 from lbleier-GSFC/enhance103-headermechanism
658df9f 
Resolves #103 Custom header mechanism
astrogeco pushed a commit to nasa/cFS that referenced this issue Jul 6, 2020
Update for nasa/cFS-GroundSystem#103
d77d764
astrogeco pushed a commit that referenced this issue Jul 6, 2020
@lbleier-GSFC
Resolve #103 - updates to allow user to select header version
6fb6e96 
Updates GUI and backend to allow user to select
header version offsets, or custom byte offsets

Also removed the shareddata.py file; no longer needed
at this time
@astrogeco astrogeco mentioned this issue Jul 6, 2020
Merged
lbleier-GSFC added a commit to lbleier-GSFC/cFS-GroundSystem that referenced this issue Jul 22, 2020
@lbleier-GSFC
Fix for enhancement nasa#103
db07727 
Issue with GUI, recompiled all .ui files
astrogeco pushed a commit that referenced this issue Jul 22, 2020
@lbleier-GSFC
HOTFIX for enhancement #103
08bcfb6 
Issue with GUI, recompiled all .ui files
@astrogeco astrogeco added this to the 2.2.0 milestone Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lbleier-GSFC lbleier-GSFC

Labels
enhancement New feature or request
Projects
None yet
Milestone
Bootes
3 participants
@skliper @astrogeco @lbleier-GSFC