Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #973, CFE_MSG_Init clear option removed #980

Merged

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Oct 28, 2020

Describe the contribution
Fix #973 - removed the clear=false logic (and clear parameter)

Testing performed
Built and ran test cases with no extended header, extended header with msgid v1, and extended header with msgid v2. All passed

Expected behavior changes
Always zeroes entire message and sets defaults.

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Oct 29, 2020
@skliper skliper added this to the 7.0.0 milestone Oct 29, 2020
@astrogeco astrogeco added CCB-20201104 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Nov 4, 2020
@astrogeco
Copy link
Contributor

CCB 2020-11-04 APPROVED

@skliper
Copy link
Contributor Author

skliper commented Nov 4, 2020

6b453be - rebased on main

@astrogeco astrogeco changed the base branch from main to integration-candidate November 10, 2020 17:22
@astrogeco astrogeco merged commit 120f3de into nasa:integration-candidate Nov 10, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 10, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Nov 16, 2020
* Add nasa/cFE#984

* Add nasa/cFE#980

* Add nasa/cFE#867

* Add nasa/osal#638 and update cfe due to rebase

* Add nasa/cFE#987

* Add nasa/to_lab#64 and nasa/sample_app#104

* Add nasa/osal#643

* Add nasa/cFE#1000

* Add nasa/ci_lab#58

* Add doxygen fixes for nasa/osal#643

* Add nasa/cFE#1013

* Add nasa/cFE#1011

* Add nasa/ci_lab#61

* Add nasa/sample_app#109

* Bump versions and point to submodules main

Co-authored-by: Joseph Hickey <joseph.p.hickey@nasa.gov>
@skliper skliper deleted the fix973-init-msg-rm-clear branch February 1, 2021 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CFE_MSG_InitMsg does not always set secondary header bit
2 participants