Fix #873, Add test for SB subscribe/unusubscribe/unsubscribe #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
CCB:FastTrack
CCB:Ready
|
Whoops... grabbed a swap file... standby |
skliper
force-pushed
the
fix873-unsub-unsub
branch
from
87cf3c1
to
b84ec17
Compare
|
Fixed w/ latest push, good to go. |
skliper
force-pushed
the
fix873-unsub-unsub
branch
from
b84ec17
to
8a4056f
Compare
|
Updated to check for 2 events, tested against #865 and it passed. |
CDKnightNASA
approved these changes
Sep 10, 2020
yammajamma
added
IC-20200909
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
This adds a test to cover the issue in #862, and verify #865 fixed it
Fix #873
Testing performed
Build and ran unit test on main branch, confirmed it produced a seg fault (as expected per #860
This should pass once #865 is checked in.
Expected behavior changes
None
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC