Fix #808: Updated the initial test to include the ES Info API calls and renamed… #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmoleski
changed the title
wmoleski
force-pushed
the
fix808-ES-api_assert-tests
branch
from
4a4882c
to
ec3311a
Compare
wmoleski
force-pushed
the
fix808-ES-api_assert-tests
branch
from
ec3311a
to
f326f06
Compare
jphickey
reviewed
Aug 31, 2020
| UtPrintf ("Task Info -> Task Name = %s\n",taskInfo.TaskName); | ||
| UtPrintf ("Task Info -> AppId = %d\n",taskInfo.AppId); | ||
| UtPrintf ("Task Info -> App Name = %s\n",taskInfo.AppName); | ||
| } |
There was a problem hiding this comment.
Recommend making all of these printfs into asserts of some type. Ideally tests should not require a manual inspection by a human - we shouldn't assume someone is necessarily looking at the result beyond pass/fail (e.g. CI testing).
If there isn't a particular value or range of values (e.g. address), perhaps just assert they are nonzero or non-empty strings.
|
@skliper what do we want to do with this? |
|
@astrogeco Leave it in draft until I have a chance to work it w/ Walt. |
skliper
added
the
CCB:Ignore
|
Duplicate of #1251 |
skliper
added
duplicate
and removed
CCB:Ignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… the source file to es_info_test.c.
Describe the contribution
Added additional ES API tests using UT_Assert and printing info structures returned from App and Task Info calls.
Testing performed
Testing was done based upon the expected returns from these API functions.
Expected behavior changes
No impact
System(s) tested on
-cFE bootes release candidate
Contributor Info - All information REQUIRED for consideration of pull request
Walt Moleski GSFC Code 582