Fix #519, Deprecate CFS/FS time conversion APIs #670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
added
enhancement
CCB:Ready
|
CCB-20200506 - APPROVED |
skliper
added
CCB-20200506
and removed
CCB:Ready
astrogeco
added
CCB:Approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Deprecates CFE_TIME_CFE2FSSeconds and CFE_TIME_FS2CFESeconds - in short the conversion/management of local OS time vs mission time isn't within the scope of cFE (it doesn't manage local OS time, so doesn't maintain an appropriate conversion factor). Utilize the CFE_FS_Header_t time for file creation if needed, synchronize local OS time with mission time, or use the return from stat as a relative (with reset caveats)
Fix #519
Testing performed
Build and unit test - SIMULATION=native ENABLE_UNIT_TESTS=true with and without OMIT_DEPRECATED=true
All passes
Expected behavior changes
None other than no longer supporting
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC