Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2605, Pass the CMAKE_PREFIX_PATH to targets #2606

Merged

Conversation

renn0xtek9
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fixes 2605. This shall enable targets under the cFS build tree to find CMake target exported from outside of the cFS build tree

Testing performed
Steps taken to test the contribution:

  1. Build steps
cp cfe/cmake/Makefile.sample Makefile
cp -r cfe/cmake/sample_defs sample_defs
make 
make all
make install

Expected behavior changes
Should be backward compatible. Not foreseeing issues

System(s) tested on

  • Hardware: PC
  • OS: Ubuntu 22.04
  • Versions: Equuleus-rc1+dev18

Additional context
Can provide with example repository where I this feature is usefull

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Maxime Haselbauer (Personal)

@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB CCB:PendingCLA External contribution pending CLA confirmation labels Sep 26, 2024
@dzbaker
Copy link
Collaborator

dzbaker commented Sep 26, 2024

Thank you @renn0xtek9 for your contribution! Would you be able to fill out a CLA (Contributor License Agreement) and email it to GSFC-SoftwareRelease@mail.nasa.gov and copy cfs-program@lists.nasa.gov? Please let me know if you have any questions about the CLA.

@renn0xtek9
Copy link
Contributor Author

Thanks for you feddback @dzbaker ! I have sent the CLA to GSFC-SoftwareRelease@mail.nasa.gov on september 24th 2024. Let me forward the E-mail to cfs-program@lists.nasa.gov and to you 👍

@renn0xtek9 renn0xtek9 force-pushed the fix-2605-Pass-CMAKE_PREFIX_PATH-to-targets branch from ce88ac6 to d436bbc Compare September 27, 2024 15:54
@dzbaker
Copy link
Collaborator

dzbaker commented Sep 27, 2024

Thanks for you feddback @dzbaker ! I have sent the CLA to GSFC-SoftwareRelease@mail.nasa.gov on september 24th 2024. Let me forward the E-mail to cfs-program@lists.nasa.gov and to you 👍

Excellent, thank you!

@renn0xtek9 renn0xtek9 force-pushed the fix-2605-Pass-CMAKE_PREFIX_PATH-to-targets branch from d436bbc to 31c8405 Compare October 2, 2024 16:15
@dzbaker dzbaker removed the CCB:PendingCLA External contribution pending CLA confirmation label Oct 3, 2024
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Maxime Haselbauer <renn0xtek9@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
@dzbaker dzbaker merged commit 90d3ed6 into nasa:main Oct 3, 2024
20 of 21 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 3, 2024
*Combines:*

cFE equuleus-rc1+dev205
to_lab equuleus-rc1+dev62

**Includes:**

*cFE*
- nasa/cFE#2602
- nasa/cFE#2606

*to_lab*
- nasa/to_lab#171
- nasa/to_lab#180

Co-authored by: Avi Weiss <thnkslprpt@users.noreply.github.com>
Co-authored by: Maxime Haselbauer <renn0xtek9@users.noreply.github.com>
Co-authored by: Anh Van <avan989@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
2 participants