Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2451, minor reorg of message headers #2453

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Puts the message encapsulation in a separate header from the message payload. Also puts all headers into the "header-check" target as there were some inclusion dependencies noted.

Fixes #2451

Testing performed
Build and run all tests

Expected behavior changes
None

System(s) tested on
Debian

Additional context
This is primarily to improve maintainability and resolve inclusion issues in other modules

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Puts the message encapsulation in a separate header from the message
payload.  Also puts all headers into the "header-check" target as there
were some inclusion dependencies noted.
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Oct 12, 2023
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Oct 12, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 18, 2023
*Combines:*

cFE v7.0.0-rc4+dev401
psp v1.6.0-rc4+dev96

**Includes:**

*cFE*
- nasa/cFE#2453

*psp*
- nasa/PSP#406
- nasa/PSP#410

Co-authored by: Anh Van <avan989@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request Oct 18, 2023
2 tasks
@dzbaker dzbaker merged commit b00f01e into nasa:main Oct 18, 2023
22 checks passed
dzbaker added a commit to nasa/cFS that referenced this pull request Oct 18, 2023
*Combines:*

cFE v7.0.0-rc4+dev401
psp v1.6.0-rc4+dev96

**Includes:**

*cFE*
- nasa/cFE#2453

*psp*
- nasa/PSP#406
- nasa/PSP#410

Co-authored by: Anh Van <avan989@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@jphickey jphickey deleted the fix-2451-msgstruct branch November 16, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate header files for message payloads and encapsulation
2 participants