Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2337, add msg verify capability #2338

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

jphickey
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Adds a "verify" API to the msg module. This always returns success in the default implementation, because checksums were not historically enforced. However it can be made more strict in a custom implementation.

Fixes #2337

Testing performed
Build and run tests (API is not used yet)

Expected behavior changes
None at this time, follow on change to enable it

System(s) tested on
Debian

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Adds a "verify" API to the msg module.  This always returns success in
the default implementation, because checksums were not historically
enforced.  However it can be made more strict in a custom
implementation.
@jphickey jphickey added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label May 18, 2023
/*
* Test MSG Verify
*/
void Test_MSG_Verify(void)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
@dzbaker dzbaker added CCB:Approved Indicates code review and approval by community CCB and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels May 18, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request May 22, 2023
*Combines:*

cFE v7.0.0-rc4+dev318
sch_lab v2.5.0-rc4+dev57

**Includes:**

*cFE*
- nasa/cFE#2336
- nasa/cFE#2338

*sch_lab*
- nasa/sch_lab#145

Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dzbaker dzbaker mentioned this pull request May 22, 2023
2 tasks
@dzbaker dzbaker merged commit ac1160c into nasa:main May 22, 2023
dzbaker added a commit to nasa/cFS that referenced this pull request May 22, 2023
*Combines:*

cFE v7.0.0-rc4+dev318
sch_lab v2.5.0-rc4+dev57

**Includes:**

*cFE*
- nasa/cFE#2336
- nasa/cFE#2338

*sch_lab*
- nasa/sch_lab#144

Co-authored by: Daniel Knutsen <dmknutsen@users.noreply.github.com>
Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
@jphickey jphickey deleted the fix-2337-verify branch May 31, 2023 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB enhancement Equuleus-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add MSG API hook to validate a message prior to returning buffer from SB
4 participants