Fix #2301, adjust UT pool buffer size for platform config #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the CFE_PLATFORM_ES_MAX_BLOCK_SIZE is increased, then increase the UT pool buffer accordingly. This had been hardcoded to 128k. Also consider pool exhaustion to be a fatal error, as continuing the test will certainly segfault and this makes the original error harder to spot.
havencarlson
added
the
CCB:Approved
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2023
*Combines:* cFE v7.0.0-rc4+dev312 **Includes:** *cFE* - nasa/cFE#2328 - nasa/cFE#2331 Co-authored by: Jose Martinez <pepepr08@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
This was referenced May 12, 2023
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2023
*Combines:* cFE v7.0.0-rc4+dev312 **Includes:** *cFE* - nasa/cFE#2328 - nasa/cFE#2331 Co-authored by: Jose Martinez <pepepr08@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
dzbaker
added a commit
to nasa/cFS
that referenced
this pull request
May 12, 2023
*Combines:* cFE v7.0.0-rc4+dev312 **Includes:** *cFE* - nasa/cFE#2328 - nasa/cFE#2331 Co-authored by: Jose Martinez <pepepr08@users.noreply.github.com> Co-authored by: Joseph Hickey <jphickey@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
If the CFE_PLATFORM_ES_MAX_BLOCK_SIZE is increased, then increase the UT pool buffer accordingly. This had been hardcoded to 128k.
Also consider pool exhaustion to be a fatal error, as continuing the test will certainly segfault and this makes the original error harder to spot.
Fixes #2301
Testing performed
Build and run TBL test with configuration specified in issue.
Expected behavior changes
TBL tests pass with larger sizes.
System(s) tested on
Debian
Additional context
Pool buffer being too small will also now stop/abort the test, as this is a bug that will certainly segfault later, better to stop and report the error more obviously.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.