Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1216, Update Directory Diagrams in App Developer Guide #1903

Conversation

ArielSAdamsNASA
Copy link

@ArielSAdamsNASA ArielSAdamsNASA commented Aug 27, 2021

Describe the contribution
Fixes #1216

Expected behavior changes
Used tree to provide a tree view of cFS, cFE, Build, and Apps.

Additional context
Did not add CS directory.

Contributor Info - All information REQUIRED for consideration of pull request
Ariel Adams, ASRC Federal

@ArielSAdamsNASA ArielSAdamsNASA added the docs This change only affects documentation. label Aug 27, 2021
@ArielSAdamsNASA ArielSAdamsNASA force-pushed the fix-1216-update-directory-diagrams-app-developer-guide branch 3 times, most recently from 4224297 to bf7bbad Compare August 27, 2021 16:47
@ArielSAdamsNASA ArielSAdamsNASA force-pushed the fix-1216-update-directory-diagrams-app-developer-guide branch from bf7bbad to 76dbe79 Compare August 27, 2021 18:11
@ArielSAdamsNASA ArielSAdamsNASA force-pushed the fix-1216-update-directory-diagrams-app-developer-guide branch from 76dbe79 to 50c139f Compare August 30, 2021 14:32
@ArielSAdamsNASA ArielSAdamsNASA added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 1, 2021
@astrogeco astrogeco removed the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Sep 1, 2021
Copy link
Contributor

@jphickey jphickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement!

As an aside, I've found the pstree command line tool to make some nice cut-and-paste-able output for this type of thing.

@astrogeco astrogeco added the CCB:Approved Indicates code review and approval by community CCB label Sep 1, 2021
@astrogeco
Copy link
Contributor

CCB:2021-09-01 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate September 7, 2021 21:42
@astrogeco astrogeco merged commit fdea0a2 into nasa:integration-candidate Sep 7, 2021
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 7, 2021
**Combines**

nasa/cFE#1939

**Includes**

*cFE*

nasa/cFE#1903, Update directory diagrams in application developer guide

nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage

nasa/cFE#1936, Improve ES code coverage
astrogeco added a commit to nasa/cFS that referenced this pull request Sep 10, 2021
**Combines**

nasa/cFE#1939, v6.8.0-rc1+dev994
nasa/osal#1145, v5.1.0-rc1+dev604
nasa/PSP#307, v1.5.0-rc1+dev124
nasa/sch_lab#87, v2.4.0-rc1+dev47

**Includes**

*cFE*

nasa/cFE#1903, Update directory diagrams in application developer guide

nasa/cFE#1922, SB code coverage improvements #1905, Improve SB coverage

nasa/cFE#1936, Improve ES code coverage

nasa/cFE#1938, Enforce minimum code coverage

nasa/cFE#1940, Update dev guide for MSG and SBR

nasa/cFE#1941, Support unimplemented features in MSG FT

*osal*

nasa/osal#1144, Regex update in coverage enforcement to match .0

nasa/osal#1142, Add typecast to memchr call

*psp*

nasa/PSP#307, check that module type is not invalid

nasa/PSP#306, do not override add_psp_module for coverage test

*sch_lab*

nasa/sch_lab#86, add CmdCode to sch_lab_table

nasa/sch_lab#88, Fix missing typedef

Co-authored-by: Jacob Hageman           <skliper@users.noreply.github.com>
Co-authored-by: Joseph Hickey           <jphickey@users.noreply.github.com>
Co-authored-by: Ariel Adams             <ArielSAdamsNASA@users.noreply.github.com>
Co-authored-by: Jose F Martinez Pedraza <pepepr08@users.noreply.github.com>
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCB:Approved Indicates code review and approval by community CCB docs This change only affects documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update directory diagrams in application developer guide
6 participants