Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1014, Remove Test_SB_Cmds_SubRptUnexpCmdCode #1113

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions fsw/cfe-core/unit-test/sb_UT.c
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ void Test_SB_Cmds(void)
SB_UT_ADD_SUBTEST(Test_SB_Cmds_SubRptOn);
SB_UT_ADD_SUBTEST(Test_SB_Cmds_SubRptOff);
SB_UT_ADD_SUBTEST(Test_SB_Cmds_CmdUnexpCmdCode);
SB_UT_ADD_SUBTEST(Test_SB_Cmds_SubRptUnexpCmdCode);
SB_UT_ADD_SUBTEST(Test_SB_Cmds_BadCmdLength);
SB_UT_ADD_SUBTEST(Test_SB_Cmds_UnexpMsgId);
} /* end Test_SB_Cmds */
Expand Down Expand Up @@ -1486,28 +1485,6 @@ void Test_SB_Cmds_CmdUnexpCmdCode(void)

} /* end Test_SB_Cmds_UnexpCmdCode */

/*
** Test command handler response to an invalid command code
*/
void Test_SB_Cmds_SubRptUnexpCmdCode(void)
{
CFE_MSG_FcnCode_t FcnCode = 99;
CFE_SB_MsgId_t MsgIdCmd = CFE_SB_ValueToMsgId(CFE_SB_SUB_RPT_CTRL_MID);

/* Second GetFcnCode is for reporting */
UT_SetDataBuffer(UT_KEY(CFE_MSG_GetMsgId), &MsgIdCmd, sizeof(MsgIdCmd), false);
UT_SetDataBuffer(UT_KEY(CFE_MSG_GetFcnCode), &FcnCode, sizeof(FcnCode), false);
UT_SetDataBuffer(UT_KEY(CFE_MSG_GetFcnCode), &FcnCode, sizeof(FcnCode), false);

/* Use a command code known to be invalid */
CFE_SB_ProcessCmdPipePkt((CFE_SB_Buffer_t *)NULL);

EVTCNT(1);

EVTSENT(CFE_SB_BAD_CMD_CODE_EID);

} /* end Test_SB_Cmds_UnexpCmdCode */

/*
** Test command handler response to an incorrect length
*/
Expand Down
16 changes: 0 additions & 16 deletions fsw/cfe-core/unit-test/sb_UT.h
Original file line number Diff line number Diff line change
Expand Up @@ -1088,22 +1088,6 @@ void Test_SB_Cmds_SubRptOff(void);
******************************************************************************/
void Test_SB_Cmds_CmdUnexpCmdCode(void);

/*****************************************************************************/
/**
** \brief Test command handler response to an invalid command code
**
** \par Description
** This function tests the command handler response to an invalid
** command code in the CFE_SB_SUB_RPT_CTRL_MID handler
**
** \par Assumptions, External Events, and Notes:
** None
**
** \returns
** This function does not return a value.
******************************************************************************/
void Test_SB_Cmds_SubRptUnexpCmdCode(void);

/*****************************************************************************/
/**
** \brief Test command handler response to a bad message length
Expand Down