Fix #997, Simplify UT_InitData SB setup #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
force-pushed
the
fix997-ut_sb_setup
branch
from
7dcc9bb
to
1a17cfc
Compare
CCB:2021-01-27 APPROVEDBoth comment and implementation were wrong. |
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Jan 27, 2021
astrogeco
added a commit
that referenced
this pull request
Feb 3, 2021
Fix #997, Simplify UT_InitData SB setup
astrogeco
added a commit
to nasa/cFS
that referenced
this pull request
Feb 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fix #997 - Removes confusing and incorrectly implemented deferred return code of -1 for
CFE_SB_ReceiveBufferfrom software bus setup in UT_InitData.Testing performed
Build and run unit tests, passed
Expected behavior changes
None in the core since nothing depended on this behavior, anything that did (other apps) should do it correctly.
System(s) tested on
Additional context
None
Third party code
None
Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC