Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 1034, Atomic type for SystemState #1035

Merged
merged 1 commit into from
Dec 16, 2020
Merged

Fix 1034, Atomic type for SystemState #1035

merged 1 commit into from
Dec 16, 2020

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Dec 3, 2020

Describe the contribution
Fix #1034

  • Use volatile sig_atomic_t for system state avoids race issue if uint32 isn't atomic on a system (microcontroller?)

Testing performed
Built and ran unit tests, passed.

Expected behavior changes
None

System(s) tested on

  • Hardware: cFS Dev Server
  • OS: Ubuntu 18.04
  • Versions: Bundle main + this commit

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Dec 9, 2020
@astrogeco astrogeco added CCB-20201209 and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Dec 9, 2020
@astrogeco
Copy link
Contributor

CCB 2020-12-09 APPROVED

@astrogeco astrogeco changed the base branch from main to integration-candidate December 16, 2020 14:38
@astrogeco astrogeco merged commit ff66d77 into nasa:integration-candidate Dec 16, 2020
astrogeco added a commit to nasa/cFS that referenced this pull request Dec 16, 2020
@astrogeco
Add nasa/cFE#1035
b3c54e5
@astrogeco astrogeco mentioned this pull request Dec 18, 2020
Merged
@skliper skliper deleted the fix1034-atomic-type branch February 1, 2021 22:05
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Caelum
Development

Successfully merging this pull request may close these issues.

Use appropriate atomic type for inter-thread sync
2 participants
@skliper @astrogeco