Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-instate "cfe_platform_cfg.h" and "cfe_mission_cfg.h" samples #2430

Closed
jphickey opened this issue Aug 18, 2023 · 1 comment · Fixed by #2431
Closed

Re-instate "cfe_platform_cfg.h" and "cfe_mission_cfg.h" samples #2430

jphickey opened this issue Aug 18, 2023 · 1 comment · Fixed by #2431
Milestone

Comments

@jphickey
Copy link
Contributor

Is your feature request related to a problem? Please describe.
These files are no longer necessary, but are still supported/usable for compatibility with existing configurations. Some long-time users expressed concern about their disappearance from the source tree.

Describe the solution you'd like
As a transitional measure, keep a copy of these files in the sample_defs directory, which shows that they are still usable.

Describe alternatives you've considered
N/A

Requester Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey
Copy link
Contributor Author

Unfortunately this creates some complexity with workflows - they will end up using the version in sample_defs instead of the default. Workflows should use the default copy.

github-actions bot pushed a commit that referenced this issue Aug 24, 2023
…ders

Fix #2430, reinstate example header files.
@dzbaker dzbaker added this to the Equuleus milestone Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants