Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uninitialized ExceptionTaskID in CFE_ES_RunExceptionScan #2402

Closed
skliper opened this issue Jul 17, 2023 · 0 comments · Fixed by #2403
Closed

Uninitialized ExceptionTaskID in CFE_ES_RunExceptionScan #2402

skliper opened this issue Jul 17, 2023 · 0 comments · Fixed by #2403
Assignees
@skliper
Labels
enhancement
Milestone
Equuleus

Comments

@skliper
Copy link
Contributor

skliper commented Jul 17, 2023

Describe the bug
Uninitialized warning:

cFE/modules/es/fsw/src/cfe_es_erlog.c

Line 277 in f6d7f8c

osal_id_t ExceptionTaskID;

Since it's not always written in:

cFE/modules/es/fsw/src/cfe_es_erlog.c

Line 294 in f6d7f8c

PspStatus = CFE_PSP_Exception_GetSummary(&PspContextId, &ExceptionTaskID, ReasonString, sizeof(ReasonString));

To Reproduce
Run static analysis

Expected behavior
No uninitialized variable warnings

System observed on:
Static analysis

Additional context
None

Reporter Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the Equuleus milestone Jul 17, 2023
@skliper skliper self-assigned this Jul 17, 2023
@skliper skliper mentioned this issue Jul 17, 2023
Merged
2 tasks
dzbaker added a commit that referenced this issue Sep 1, 2023
@dzbaker
Merge pull request #2403 from skliper:fix2402-uninit_exceptinotaskid
5309e80 
Fix #2402, Uninitialized ExceptionTaskID in CFE_ES_RunExceptionScan
@dzbaker dzbaker mentioned this issue Sep 1, 2023
Merged
2 tasks
@dzbaker dzbaker closed this as completed in 2afb134 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement
Projects
None yet
Milestone
Equuleus
Development

Successfully merging a pull request may close this issue.

Fix #2402, Uninitialized ExceptionTaskID in CFE_ES_RunExceptionScan skliper/cFE
2 participants
@skliper @chillfig