You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
The MemAddress and MemOffset types defined by ES are 32 bits by default, but are intended to be expandable to 64. These should be used for CMD/TLM fields that need to hold a memory address on a 64-bit machine, or the size of an object in memory on such a machine.
However TBL services uses this type in some other locations, that generally do not need it. Notably, this calls 32-bit byte swapping routines to read/write this field, and that will not work if the size becomes 64 bits.
Describe the solution you'd like
These fields in table services will need to remain 32 bits regardless of the CPU address size.
Need to make sure that the correct macro - CFE_ES_MEMOFFSET_C or CFE_ES_MEMADDRESS_C is used when setting the value. Notably, this macro can provide the correct read/write logic in case the MemAddress needs to be a struct with a high and low word, for example.
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
Is your feature request related to a problem? Please describe.
The MemAddress and MemOffset types defined by ES are 32 bits by default, but are intended to be expandable to 64. These should be used for CMD/TLM fields that need to hold a memory address on a 64-bit machine, or the size of an object in memory on such a machine.
However TBL services uses this type in some other locations, that generally do not need it. Notably, this calls 32-bit byte swapping routines to read/write this field, and that will not work if the size becomes 64 bits.
Describe the solution you'd like
CFE_ES_MEMOFFSET_C
orCFE_ES_MEMADDRESS_C
is used when setting the value. Notably, this macro can provide the correct read/write logic in case the MemAddress needs to be a struct with a high and low word, for example.Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: