Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter for sizeof check in cfe_tbl_task #2220

Closed
ndijkhof opened this issue Dec 1, 2022 · 0 comments · Fixed by #2222 or #2226
Closed

Add parameter for sizeof check in cfe_tbl_task #2220

ndijkhof opened this issue Dec 1, 2022 · 0 comments · Fixed by #2222 or #2226
Labels
draco-rc4
Milestone
Draco

Comments

@ndijkhof
Copy link

ndijkhof commented Dec 1, 2022 •
edited
Loading

Macro CFE_TBL_MESSAGE_ENTRY in cfe_tbl_task.c uses a static structure typedef for the sizeof check that is causing issues with a new feature.

Add new macro input parameter to have the structure type passed for sizeof check similar to macro CFE_TBL_COMMAND_ENTRY. Also change line 68 of cfe_tbl_task.c to have the macro input parameter to be CFE_TBL_NoArgsCmd_t as seen below:

CFE_TBL_MESSAGE_ENTRY(CFE_TBL_SEND_HK_MID, CFE_TBL_NoArgsCmd_t, CFE_TBL_HousekeepingCmd)

Nicholas Dijkhoffz JSC/METECs
@dmknutsen dmknutsen mentioned this issue Dec 5, 2022
Merged
dzbaker added a commit that referenced this issue Dec 6, 2022
@dzbaker
Merge pull request #2222 from dmknutsen/Issue_2220
85242a3 
Fix #2220, Combine MESSAGE and CMD ENTRY Macros
@dzbaker dzbaker mentioned this issue Dec 6, 2022
Merged
2 tasks
@dzbaker dzbaker closed this as completed in 22272c9 Dec 6, 2022
dmknutsen pushed a commit to dmknutsen/cFE that referenced this issue Dec 6, 2022
Fix nasa#2220, Replace CFE_MSG_CommandHeader_t w/ CFE_TBL_NoArgsCmd_t
3577b6c
@dmknutsen dmknutsen mentioned this issue Dec 6, 2022
Merged
dzbaker added a commit that referenced this issue Dec 7, 2022
@dzbaker
Merge pull request #2226 from dmknutsen/Issue_2220
8434bf4 
Fix #2220, Replace CFE_MSG_CommandHeader_t w/ CFE_TBL_NoArgsCmd_t
@dzbaker dzbaker mentioned this issue Dec 7, 2022
Merged
2 tasks
This was referenced Dec 7, 2022
Closed
Merged
@dmknutsen dmknutsen added this to the Draco milestone Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draco-rc4
Projects
None yet
Milestone
Draco
2 participants
@dmknutsen @ndijkhof