Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SB functional test - add verification that unsubscribe actually unsubcribes #1825

Closed
skliper opened this issue Aug 16, 2021 · 0 comments · Fixed by #1876 or #1885
Closed

SB functional test - add verification that unsubscribe actually unsubcribes #1825

skliper opened this issue Aug 16, 2021 · 0 comments · Fixed by #1876 or #1885
Assignees
@jphickey
Labels
functional unit-test
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Aug 16, 2021

Is your feature request related to a problem? Please describe.
Although there are nominal calls in sb_subscription_test.c and messages are sent/received (after a subscription) in sb_sendrecv_test.c, there's no functional check that after unsubscribing from a message it is no longer received.

Unsubscribe also isn't used by the services (although it is used by GSFC apps).

Describe the solution you'd like
Add at minimum a verification of the unsubscribe. Would be nice to also add just a simple send/receive for each subscribe type in sb_subscription_test.c since only CFE_SB_SubscribeEx is utilized in the sendrecv test (and it's helpful have the test self contained).

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Aug 16, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Aug 24, 2021
@jphickey
Fix nasa#1825, test unsubscribe from single pipe
b108e7e 
Extends the broadcast test case to cover unsubscription of a single pipe ID.
Confirms that other pipes/subscriptions are not affected, and that the limits
initially enforced on those original subscriptions still apply.
@jphickey jphickey mentioned this issue Aug 24, 2021
Merged
astrogeco added a commit that referenced this issue Aug 27, 2021
@astrogeco
Merge pull request #1876 from jphickey/fix-1825-1826-1829-1830-sb-tests
98d723e 
Fix #1825, #1826, #1829, #1830, SB test improvements
@astrogeco astrogeco mentioned this issue Aug 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
functional unit-test
Projects
None yet
Milestone
Caelum
2 participants
@jphickey @skliper