Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Order event ID's and fix duplicates #1583

Closed
skliper opened this issue May 26, 2021 · 0 comments · Fixed by #1594
Closed

Order event ID's and fix duplicates #1583

skliper opened this issue May 26, 2021 · 0 comments · Fixed by #1594
Assignees
@skliper
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented May 26, 2021

Is your feature request related to a problem? Please describe.
The whole "MAX EID" concept for avoiding conflicts is poorly followed, out of order EID's then lead to collisions. Just one example shown here (there are multiple):

cFE/modules/sb/fsw/inc/cfe_sb_events.h

Line 195 in 176e3df

#define CFE_SB_GETPIPENAME_EID 62

cFE/modules/sb/fsw/inc/cfe_sb_events.h

Line 892 in 176e3df

#define CFE_SB_CR_PIPE_NAME_TAKEN_EID 62

Describe the solution you'd like
Order EID's by number. Put new ones at the end. Remove the unused MAX EID value which is fragile anyways.

Describe alternatives you've considered
None

Additional context
#1320 - incorrect max

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone May 26, 2021
@skliper skliper mentioned this issue May 26, 2021
Closed
@skliper skliper self-assigned this May 26, 2021
skliper added a commit to skliper/cFE that referenced this issue May 27, 2021
@skliper
Fix nasa#1320 nasa#1583, Order event ids and remove max
61ea145
@skliper skliper mentioned this issue Jun 1, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue Jun 9, 2021
@skliper
Fix nasa#1320 nasa#1583, Order event ids and remove max
45469db
skliper added a commit to skliper/cFE that referenced this issue Jun 17, 2021
@skliper
Fix nasa#1320 nasa#1583, Order event ids and remove max
961b752
astrogeco added a commit that referenced this issue Jun 23, 2021
@astrogeco
Merge pull request #1594 from skliper/fix1320-es_max_eid
63a5a31 
Fix #1320 #1583 #508, Event ID updates
@astrogeco astrogeco mentioned this issue Jun 23, 2021
Merged
@skliper skliper closed this as completed Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skliper skliper

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #1320 #1583 #508, Event ID updates skliper/cFE
1 participant
@skliper