Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use void * for CFE_ES_PoolCreateNoSem memory pointer #1317

Closed
skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1379 or #1431
Closed

Use void * for CFE_ES_PoolCreateNoSem memory pointer #1317

skliper opened this issue Apr 13, 2021 · 0 comments · Fixed by #1379 or #1431
Assignees
@jphickey
Labels
CFS-40 enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Apr 13, 2021

Is your feature request related to a problem? Please describe.
Other routines use void *, CFE_ES_PoolCreateNoSem uses uint8 *:

cFE/modules/core_api/fsw/inc/cfe_es.h

Line 1193 in e80aae9

CFE_Status_t CFE_ES_PoolCreateNoSem(CFE_ES_MemHandle_t *PoolID, uint8 *MemPtr, size_t Size);

Describe the solution you'd like
Make consistent

Describe alternatives you've considered
Maybe there was a reason, analyze and if so document

Additional context
Code review

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Apr 13, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Apr 19, 2021
@jphickey
Fix nasa#1317, memory pool pointer type
24b9a3b 
Changes the type of pointer in the API from uint8* to void* to be
more consistent and easier to use.  Should be backward compatible.

This also updates the doxygen documentation for this parameter, as
it was specifying a 32-bit alignment requirement whereas the
alignment requirement is processor dependent - 64 bit processors
typically will need 64 bit alignment.  Link to the macro which
is intended to aid in aligning the static pool buffer.
@jphickey jphickey mentioned this issue Apr 19, 2021
Merged
astrogeco added a commit that referenced this issue Apr 28, 2021
@astrogeco
Merge pull request #1379 from jphickey/fix-1317-pool-memtype
ef9ab99 
Fix #1317, memory pool pointer type
@astrogeco astrogeco mentioned this issue Apr 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
CFS-40 enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

Fix #1317, memory pool pointer type jphickey/cFE
cFE Integration candidate: 2021-04-27 nasa/cFE
2 participants
@jphickey @skliper