Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CFE_ES_GetAppID missing null pointer check #1267

Closed
zanzaben opened this issue Mar 26, 2021 · 1 comment · Fixed by #1268 or #1258
Closed

CFE_ES_GetAppID missing null pointer check #1267

zanzaben opened this issue Mar 26, 2021 · 1 comment · Fixed by #1268 or #1258
Assignees
@zanzaben
Labels
enhancement
Milestone
Caelum

Comments

@zanzaben
Copy link
Contributor

Describe the bug
CFE_ES_GetAppID doesn't have a null pointer check and seg faults if passed one.

To Reproduce
Call it with a null pointer

Expected behavior
Should return CFE_ES_BAD_ARGUMENT

System observed on:
Ubuntu 20.04

Reporter Info
Alex Campbell GSFC
@zanzaben zanzaben self-assigned this Mar 26, 2021
zanzaben added a commit to zanzaben/cFE that referenced this issue Mar 26, 2021
@zanzaben
Fix nasa#1267, add null pointer check
4c33529
@zanzaben
Copy link
Contributor Author

CFE_ES_GetTaskID is also missing a null pointer check.

@zanzaben zanzaben mentioned this issue Mar 26, 2021
Merged
@skliper skliper added this to the 7.0.0 milestone Mar 30, 2021
@astrogeco astrogeco mentioned this issue Mar 30, 2021
Merged
astrogeco added a commit that referenced this issue Mar 30, 2021
@astrogeco
Merge pull request #1271 from zanzaben/fix1267_GetAppId_null_pointer
db39522 
Fix #1267, add null pointer check
Fix #1269, refactor CFE_ES_ERR_BUFFER to CFE_ES_BAD_ARGUMENT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zanzaben zanzaben

Labels
enhancement
Projects
None yet
Milestone
Caelum
2 participants
@zanzaben @skliper