Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"PipeName" is unset for debug event #1141

Closed
jphickey opened this issue Jan 29, 2021 · 0 comments · Fixed by #1142 or #1150
Closed

"PipeName" is unset for debug event #1141

jphickey opened this issue Jan 29, 2021 · 0 comments · Fixed by #1142 or #1150
Assignees
Milestone

Comments

@jphickey
Copy link
Contributor

Describe the bug
Mistake in previous PR #1092 where the PipeName buffer is used to send a debug event on success but it is only set to a value on failure.

To Reproduce
Enabled debug events, and "Subscription Rcvd" events do not have a valid name.

Expected behavior
Need to get name in all cases, not just failure.

System observed on:
Ubuntu 20.04

Additional context
My preference would be to only print the ID in a debug event, as its faster and it saves the work of copying the name since most of the time debug events are turned off anyway. But a "quick fix" that doesn't change the format is to just move the line.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.

@jphickey jphickey self-assigned this Jan 29, 2021
jphickey added a commit to jphickey/cFE that referenced this issue Jan 29, 2021
Get the pipe name all the time, not just for failure events.
jphickey added a commit to jphickey/cFE that referenced this issue Jan 29, 2021
Do not print the pipe name in the debug event, just pipe ID.
@astrogeco astrogeco added this to the 7.0.0 milestone Feb 3, 2021
astrogeco added a commit that referenced this issue Feb 3, 2021
jphickey added a commit that referenced this issue Feb 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants