Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Test_SB_Cmds_SubRptUnexpCmdCode (no longer applicable) #1014

Closed
skliper opened this issue Nov 13, 2020 · 0 comments · Fixed by #1113 or #1150
Closed

Remove Test_SB_Cmds_SubRptUnexpCmdCode (no longer applicable) #1014

skliper opened this issue Nov 13, 2020 · 0 comments · Fixed by #1113 or #1150
Labels
bug removed unit-test
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Nov 13, 2020

Is your feature request related to a problem? Please describe.
Test_SB_Cmds_SubRptUnexpCmdCode seems like it was intended to test the subscription reporting with a command code parameter, but this is a no parameter command. It's also just a copy of Test_SB_Cmds_UnexpCmdCode so doesn't do anything unique.

Describe the solution you'd like
Remove.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
@skliper skliper added this to the 7.0.0 milestone Nov 13, 2020
skliper added a commit to skliper/cFE that referenced this issue Jan 21, 2021
@skliper
Fix nasa#1014, Remove Test_SB_Cmds_SubRptUnexpCmdCode
bc24083 
Test was just a copy/paste of Test_SB_Cmds_CmdUnexpCmdCode
and did not actually implement a new test.  Subscription
reporting is a no parameter command.
@skliper skliper mentioned this issue Jan 21, 2021
Merged
skliper added a commit to skliper/cFE that referenced this issue Jan 27, 2021
@skliper
Fix nasa#1014, Remove Test_SB_Cmds_SubRptUnexpCmdCode
9740572 
Test was just a copy/paste of Test_SB_Cmds_CmdUnexpCmdCode
and did not actually implement a new test.  Subscription
reporting is a no parameter command.
@astrogeco astrogeco added the bug label Feb 3, 2021
astrogeco added a commit that referenced this issue Feb 3, 2021
@astrogeco
Merge pull request #1113 from skliper/fix1014-subrptunexpcmdcode
bb8e351 
Fix #1014, Remove Test_SB_Cmds_SubRptUnexpCmdCode
@astrogeco astrogeco mentioned this issue Feb 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug removed unit-test
Projects
None yet
Milestone
Caelum
2 participants
@skliper @astrogeco