Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict cppcheck static analysis style warnings #24

Closed
3 tasks done
skliper opened this issue May 6, 2022 · 0 comments · Fixed by #26
Closed
3 tasks done

Strict cppcheck static analysis style warnings #24

skliper opened this issue May 6, 2022 · 0 comments · Fixed by #26

Comments

@skliper
Copy link
Contributor

skliper commented May 6, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Fails cppcheck strict static analysis workflow as seen here (https://github.com/nasa/SC/runs/6327782270?check_suite_focus=true)

[fsw/src/sc_atsrq.h:66] -> [fsw/src/sc_atsrq.c:50]: (style, inconclusive) Function 'SC_StartAtsCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_atsrq.h:83] -> [fsw/src/sc_atsrq.c:131]: (style, inconclusive) Function 'SC_StopAtsCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_atsrq.h:47] -> [fsw/src/sc_atsrq.c:181]: (style, inconclusive) Function 'SC_BeginAts' argument 1 names different: declaration 'AtsId' definition 'AtsIndex'.
[fsw/src/sc_atsrq.h:117] -> [fsw/src/sc_atsrq.c:305]: (style, inconclusive) Function 'SC_GroundSwitchCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_atsrq.h:187] -> [fsw/src/sc_atsrq.c:508]: (style, inconclusive) Function 'SC_JumpAtsCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_atsrq.h:203] -> [fsw/src/sc_atsrq.c:637]: (style, inconclusive) Function 'SC_ContinueAtsOnFailureCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_atsrq.h:222] -> [fsw/src/sc_atsrq.c:669]: (style, inconclusive) Function 'SC_AppendAtsCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_cmds.h:161] -> [fsw/src/sc_cmds.c:492]: (style, inconclusive) Function 'SC_ResetCountersCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_cmds.h:146] -> [fsw/src/sc_cmds.c:514]: (style, inconclusive) Function 'SC_NoOpCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_cmds.h:117] -> [fsw/src/sc_cmds.c:529]: (style, inconclusive) Function 'SC_ProcessRequest' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_cmds.h:131] -> [fsw/src/sc_cmds.c:637]: (style, inconclusive) Function 'SC_ProcessCommand' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_cmds.h:47] -> [fsw/src/sc_cmds.c:733]: (style, inconclusive) Function 'SC_TableManageCmd' argument 1 names different: declaration 'CmdPacket' definition 'BufPtr'.
[fsw/src/sc_loads.h:47] -> [fsw/src/sc_loads.c:390]: (style, inconclusive) Function 'SC_ParseRts' argument 1 names different: declaration 'Buffer' definition 'Buffer32'.
[fsw/src/sc_loads.h:110] -> [fsw/src/sc_loads.c:697]: (style, inconclusive) Function 'SC_VerifyAtsTable' argument 1 names different: declaration 'Buffer' definition 'Buffer32'.
[fsw/src/sc_loads.h:126] -> [fsw/src/sc_loads.c:762]: (style, inconclusive) Function 'SC_VerifyAtsEntry' argument 1 names different: declaration 'Buffer' definition 'Buffer32'.

Describe the solution you'd like
Fix the name inconsistencies.

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone May 6, 2022
skliper added a commit to skliper/SC that referenced this issue May 9, 2022
astrogeco added a commit that referenced this issue May 11, 2022
Fix #24, Resolve strict cppcheck style warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant