Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE_PSP_MemCpy doesn't handle overlapping ranges #36

Closed
skliper opened this issue Sep 25, 2019 · 8 comments
Closed

CFE_PSP_MemCpy doesn't handle overlapping ranges #36

skliper opened this issue Sep 25, 2019 · 8 comments
Labels
bug Something isn't working wontfix This will not be worked on

Comments

@skliper
Copy link
Contributor

skliper commented Sep 25, 2019

CFE_PSP_MemCpy() in cfe_psp_memutils.c does not contain any logic for handling the case where the source and destination memory regions overlap.

The current grut699-vxworks6 implementation currently calls the C memcpy(), which is documented to have undefined behavior in this case.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Imported from trac issue 32. Created by abrown4 on 2015-08-11T15:29:48, last modified: 2019-06-13T10:49:57

@skliper skliper self-assigned this Sep 25, 2019
@skliper skliper added bug Something isn't working wontfix This will not be worked on labels Sep 25, 2019
@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by abrown4 on 2015-08-11 15:34:55:

Tested with commit: [changeset:a0a2a9b] & [changeset:05dfc40] Trac #14 Added white-box test for cfe_psp_memutils.c.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by sduran on 2015-08-17 11:51:53:

The implementation is consistent with the underlying lib call. Maybe add a comment to remind developers that src and dst memory regions cannot overlap.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by abrown4 on 2015-08-17 13:00:30:

commit: [changeset:9d4e23d] Trac #36 Updated CFE_PSP_MemCpy() documentation (header) for overlapping ranges. No behavioral or API changes.

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by abrown4 on 2015-08-17 15:43:01:

merged to branch #14 in commit: [changeset:2234ae6].

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jhageman on 2019-05-08 13:51:41:

Discussed at CCB 5/8/2019, should talk #34 #35 #36 from a design perspective (should this abstraction be removed?)

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jhageman on 2019-06-10 14:56:52:

Marked for CCB review - related to #10 suggest "wontfix", mark functions as deprecated)

@skliper
Copy link
Contributor Author

skliper commented Sep 25, 2019

Trac comment by jhageman on 2019-06-13 10:49:57:

CCB 6/12/19 - Agreed to deprecate, opened #97 to address this (rather than hijack this ticket). Closing as wontfix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant