Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static analysis issues JSC 2.1 #92

Closed
2 tasks done
chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #93
Closed
2 tasks done

Static analysis issues JSC 2.1 #92

chillfig opened this issue Apr 24, 2024 · 0 comments · Fixed by #93
Assignees
Labels

Comments

@chillfig
Copy link
Contributor

chillfig commented Apr 24, 2024

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
Handful of static analysis issues. This report records the findings from the static analysis to facilitate their tracking.

Source Folder Source Filename Source Line Source Object Disposition
Unchecked Return Value on Function        
\apps\mm\fsw\src mm_app.c 515 strncpy Will Fix. MM PR #93
\apps\mm\fsw\src mm_dump.c 329 strncpy Will Fix. MM PR #93
\apps\mm\fsw\src mm_app.c 443 strlen Will Fix. MM PR #93
\apps\mm\fsw\src mm_app.c 503 strlen Will Fix. MM PR #93
\apps\mm\fsw\src mm_dump.c 528 strlen Will Fix. MM PR #93
\apps\mm\fsw\src mm_dump.c 541 strlen Will Fix. MM PR #93
Unchecked Return Value on Function        
\apps\mm\fsw\src mm_dump.c 549 snprintf Will Not Fix. No need to check snprintf return; CFE_SB_MessageStringGet() handles safe concatenation and prevents overflow.
\apps\mm\fsw\src mm_utils.c 351 snprintf Will Not Fix. No need to check snprintf return value; buffer size can store "MEM_RAM" without overflow.
\apps\mm\fsw\src mm_utils.c 367 snprintf Will Not Fix. No need to check snprintf return value; buffer size can store "MEM_EEPROM" without overflow.

To Reproduce
N/A. These issues were communicated by JSC.

Expected behavior
Need to resolve these. Should resolve and/or disposition the higher ranked ones at minimum.

Code snips
N/A

System observed on:
N/A

Additional context
N/A

Reporter Info
Imported from JSC 2.1 static analysis

@chillfig chillfig added the bug label Apr 24, 2024
@chillfig chillfig self-assigned this Apr 24, 2024
chillfig pushed a commit to chillfig/MM that referenced this issue Jun 10, 2024
chillfig pushed a commit to chillfig/MM that referenced this issue Jun 13, 2024
…nprintf

This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
chillfig pushed a commit to chillfig/MM that referenced this issue Jun 18, 2024
This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with MM_strnlen.
chillfig pushed a commit to chillfig/MM that referenced this issue Jun 18, 2024
This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with MM_strnlen.
chillfig pushed a commit to chillfig/MM that referenced this issue Jun 21, 2024
This commit addresses issues flagged during static analysis by:
- Adding JSC 2.1 disposition comments.
- Replacing strncpy with snprintf to enhance safety and compliance.
- Replacing strlen with OS_strnlen.
@dzbaker dzbaker closed this as completed in 0409a4a Jul 2, 2024
dzbaker added a commit that referenced this issue Jul 2, 2024
Fix #92, Adds static analysis comments, replaces strncpy and strlen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant