Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define and use Topic IDs instead of fixed Msg IDs #114

Closed
3 tasks done
jphickey opened this issue Dec 18, 2023 · 0 comments · Fixed by #115
Closed
3 tasks done

Define and use Topic IDs instead of fixed Msg IDs #114

jphickey opened this issue Dec 18, 2023 · 0 comments · Fixed by #115
Assignees
@jphickey

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
The "topic ID" concept allows MsgID values to be assigned using a logical pattern for multiple CPUs. This is much more flexible for an out-of-the-box config than fixed MsgIDs.

Describe the solution you'd like
Define application msgids based on the topic ID and conversion macro.

Additional context
This won't change the message IDs for the default case, just makes them easier to manage for various use cases.

Requester Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Dec 18, 2023
jphickey added a commit to jphickey/HS that referenced this issue Dec 19, 2023
@jphickey
Fix nasa#114, clean up dispatch logic
bcab408 
Next step in adherence to established patterns for headers
and dispatch code.

- Define MsgIDs for HS based on TopicIDs
- Define Command Handlers based on pattern (CFE_Status_t return, command structure type input)
- Define EDS dispatcher
@jphickey jphickey mentioned this issue Dec 19, 2023
Merged
2 tasks
jphickey added a commit to jphickey/HS that referenced this issue Dec 19, 2023
@jphickey
Fix nasa#114, clean up dispatch logic
2cadd38 
Next step in adherence to established patterns for headers
and dispatch code.

- Define MsgIDs for HS based on TopicIDs
- Define Command Handlers based on pattern (CFE_Status_t return, command structure type input)
- Define EDS dispatcher
dzbaker added a commit that referenced this issue Jan 4, 2024
@dzbaker
Merge pull request #115 from jphickey/fix-114-topicids
312aa74 
Fix #114, clean up dispatch logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #114, clean up dispatch logic jphickey/HS
1 participant
@jphickey