MsgID check should use SB wrapper #79
Assignees
Labels
bug
Something isn't working
Comments
jphickey
added a commit
to jphickey/EdsLib
that referenced
this issue
Jan 22, 2024
Use the "CFE_SB_IsValidMsgId()" function to check msgids, as this is the source of truth.
jphickey
added a commit
to jphickey/EdsLib
that referenced
this issue
Jan 22, 2024
Use the "CFE_SB_IsValidMsgId()" function to check msgids, as this is the source of truth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The MsgId validity check should use the SB IsValidMsgId() check, rather than checking against a fixed maximum. This is the same change as was in nasa/cFE#2489 but EDS has its own msg implementation (originally cloned from the CFE msg module) but this still has the same check and thus needs to be changed here too.
To Reproduce
N/A
Expected behavior
MsgID validity check should be consistent everywhere
Additional context
Single source of truth here should be via
CFE_SB_IsValidMsgId()Reporter Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: