Incorporate PR #112 feedback

- Move `DirName` directory to beginning of function - Remove redundant `sizeof(char)`
nasa · Nov 30, 2023 · 5ca72f0 · 5ca72f0
1 parent 0bedf4c
commit 5ca72f0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/unit-test/ds_file_tests.c b/unit-test/ds_file_tests.c
@@ -960,12 +960,12 @@ void DS_FileCloseDest_Test_PlatformConfigMoveFiles_MoveError(void)
 void DS_FileCloseDest_Test_PlatformConfigMoveFiles_FilenameTooLarge(void)
 {
     int32 FileIndex = 0;
-
+    const char DirName[] = "directory1/";
+
     /* Set up the handle */
     OS_OpenCreate(&DS_AppData.FileStatus[FileIndex].FileHandle, NULL, 0, 0);
-
-    const char DirName[] = "directory1/";
-    size_t DirNameLen = sizeof(DirName)/sizeof(char);
+
+    size_t DirNameLen = sizeof(DirName);
     strncpy(DS_AppData.FileStatus[FileIndex].FileName, DirName, DirNameLen);
     memset(&DS_AppData.FileStatus[FileIndex].FileName[DirNameLen-1], 'f', DS_TOTAL_FNAME_BUFSIZE - DirNameLen);
     DS_AppData.FileStatus[FileIndex].FileName[DS_TOTAL_FNAME_BUFSIZE-1] = '\0';