Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CS CRC values may lead to confusion #22

Open
skliper opened this issue Apr 22, 2022 · 0 comments
Open

CS CRC values may lead to confusion #22

skliper opened this issue Apr 22, 2022 · 0 comments
Labels

Comments

@skliper
Copy link
Contributor

skliper commented Apr 22, 2022

The CS application relies on the CFE_ES_CalculateCRC function to report the CRCs that it calculates. However, this function calculates the CRC as an int16 value and returns that value as a uint32 value. This causes the sign bit of the int16 (bit 15) to be propagated to the upper 16 bits of the uint32. If this bit is set, it can cause confusion since a CRC of 0x845E would result in the CS application having a value of 0xFFFF845E.

Imported from GSFCCFS-929

@skliper skliper added the bug label Apr 22, 2022
skliper added a commit to skliper/CS that referenced this issue Sep 9, 2022
skliper added a commit to skliper/CS that referenced this issue Sep 9, 2022
skliper added a commit to skliper/CS that referenced this issue Sep 9, 2022
skliper pushed a commit to skliper/CS that referenced this issue Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant