Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #118, failed commands send error event message #282

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

havencarlson
Copy link
Contributor

Checklist (Please check before submitting)

Describe the contribution
Fix #118 , an error event message is sent if a command is not successful

Testing performed
Ran unit tests

Expected behavior changes
Behavior Change: All commands now send an error event message if unsuccessful

System(s) tested on
OS: Ubuntu 18.04

Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 11 potential problems in the proposed changes. Check the Files changed tab for more details.

@skliper skliper requested a review from semaldona July 18, 2022 12:34
@havencarlson havencarlson added the CCB:Ready Ready for discussion at the Configuration Control Board (CCB) label Jul 18, 2022
@dzbaker dzbaker added CCB:Approved and removed CCB:Ready Ready for discussion at the Configuration Control Board (CCB) labels Jul 20, 2022
@dzbaker dzbaker merged commit 3593288 into nasa:main Jul 20, 2022
@skliper skliper added this to the Draco milestone Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants