Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various type mismatches in CF #430

Closed
2 tasks done
jphickey opened this issue Jan 10, 2024 · 0 comments · Fixed by #431
Closed
2 tasks done

Various type mismatches in CF #430

jphickey opened this issue Jan 10, 2024 · 0 comments · Fixed by #431
Assignees
@jphickey

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CF source code has a number of type mismatches that may or may not be picked up by the compiler (due to platform variations).

In particular:

  • List traversal functions (CF_CListFn_t used by CF_CList_Traverse() have a custom return type, it is not CFE_Status_t)
  • Channel action functions (CF_ChanActionFn_t have a custom return type, it is not CFE_Status_t)
  • Numerous mismatches between int and long and the printf format specifiers

To Reproduce
Build on a platform which does not match assumptions about type equality

Expected behavior
Build should succeed

System observed on:
Debian, RTEMS 4.11

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
@jphickey jphickey self-assigned this Jan 10, 2024
jphickey added a commit to jphickey/CF that referenced this issue Jan 10, 2024
@jphickey
Fix nasa#430, correct type mismatches
ace7b1a 
Correction for various type mismatches across CF.
Notably, many iterators do not use the CFE_Status_t return
type, it should be a custom enum.
@jphickey jphickey mentioned this issue Jan 10, 2024
Merged
2 tasks
dzbaker added a commit that referenced this issue Jan 11, 2024
@dzbaker
Merge pull request #431 from jphickey/fix-430-type-mismatch
0a9d4a1 
Fix #430, correct type mismatches
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #430, correct type mismatches jphickey/CF
1 participant
@jphickey