Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent results in coverage test #249

Closed
3 tasks done
skliper opened this issue May 24, 2022 · 2 comments · Fixed by #250
Closed
3 tasks done

Inconsistent results in coverage test #249

skliper opened this issue May 24, 2022 · 2 comments · Fixed by #250
Labels
draco-rc2 unit-test Related to coverage or functional tests
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented May 24, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the CF README.md file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
Likely related to random number use in unit tests (#228

Failed coverage here: https://github.com/skliper/CF/runs/6581159060?check_suite_focus=true

Overall coverage rate:
  lines......: 99.9% (2678 of 2681 lines)
  functions..: 100.0% (258 of 258 functions)
  branches...: 99.2% (1056 of 1065 branches)
9 branches missed, 8 allowed
3 lines missed, 2 allowed

Note it passed in the very next run w/ no code changes (was just a requirements update)

Describe the solution you'd like
Remove whatever random test implementation is causing this (all others eventually to fix #86)

Describe alternatives you've considered
None

Additional context
#86

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added the unit-test Related to coverage or functional tests label May 24, 2022
@skliper skliper added this to the Draco milestone May 24, 2022
@skliper
Copy link
Contributor Author

skliper commented May 24, 2022

Bad run RANDOM_VALUES_SEED = 1653424171
Good run = 1653424499

@skliper
Copy link
Contributor Author

skliper commented May 24, 2022

Additional missing line/branch:

     232                 :          6 : CF_ChunkIdx_t CF_Chunks_FindSmallestSize(const CF_ChunkList_t *chunks)
     233                 :            : {
     234                 :            :     CF_ChunkIdx_t i;
     235                 :          6 :     CF_ChunkIdx_t smallest = 0;
     236                 :            : 
     237         [ +  + ]:         35 :     for (i = 1; i < chunks->count; ++i)
     238                 :            :     {
     239         [ -  + ]:         29 :         if (chunks->chunks[i].size < chunks->chunks[smallest].size)
     240                 :            :         {
     241                 :          0 :             smallest = i;
     242                 :            :         }
     243                 :            :     }
     244                 :            : 
     245                 :          6 :     return smallest;
     246                 :            : }

skliper added a commit to skliper/CF that referenced this issue May 24, 2022
astrogeco added a commit that referenced this issue May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
draco-rc2 unit-test Related to coverage or functional tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant