Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update preconfigured_peers comment with IP example #3045

Closed
zhyatt opened this issue Nov 9, 2020 · 0 comments · Fixed by #3282
Closed

Update preconfigured_peers comment with IP example #3045

zhyatt opened this issue Nov 9, 2020 · 0 comments · Fixed by #3282
Assignees
Milestone

Comments

@zhyatt
Copy link
Collaborator

zhyatt commented Nov 9, 2020

The previous .json type config files had the following default setup which included an example of a non-domain based entry:

"preconfigured_peers": [ // List of defaults peers to connect on boot
            "peering.nano.org",
            "::ffff:138.201.94.249"
        ]

Currently we rely on comments in the example/generated .toml file for hints and although it mentions IP addresses, it seems like IPv6 is required and that isn't mentioned. It currently shows:

# A list of "address" (hostname or ip address) entries to identify preconfigured peers.
#preconfigured_peers = ["peering.nano.org"]

This should be clarified further in the comment/hints of the generated .toml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants