-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphView nodeWidget not clickable on bottom boundary region #102
Comments
Any code to reproduce? |
I have the same problem, and I found if I adjust Level Separation smaller, it will be normal |
Here is code to reproduce:
|
It's because when algorithm is ran, it's called with Is there any reason to do that @nabil6391, looks like it was made to have some kind of padding but this seems wrong to me. We should either be able to configure the coordinate shifting ourselves or the size should be calculated accordingly (+20 on x and y to get a consistent box) (BuchheimWalkerAlgorithm.dart L112) As a temporary solution, you can extend your preferred algorithm and suppress the shifting : class Algorithm extends BuchheimWalkerAlgorithm {
Algorithm(super.configuration, super.renderer);
@override
Size run(Graph? graph, double shiftX, double shiftY) => super.run(graph, 0, 0);
} |
Thats a good find and honestly I am not sure why we do the shift, can you help create a PR with the fix and then I can take a look |
That should be an easy fix but I'm way too busy right now to take time for it, I'm sorry. But if anyone come accross this issue, he can easily contribute as I've provided all the necessary. Ideally, shiftX and shiftY would become a parameter defaulting to Offset.zero |
If we try to interact with graphview leaf node widget on bottom boundary areas, it behaves abnormally and remains unclickable.
The text was updated successfully, but these errors were encountered: