Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove handleValidationErrors and handleParseErrors options from useMaskedErrors #1482

Closed
n1ru4l opened this issue Aug 16, 2022 · 0 comments
Closed
Assignees
Milestone

Comments

@n1ru4l
Copy link
Owner

n1ru4l commented Aug 16, 2022

useMaskedErrors should be scoped to the execution and context creation.

Masking validation errors ONLY makes sense when introspection is disabled.

ONLY masking validation errors OR ONLY disabling introspection errors does not make sense, as both can be abused for reverse-engineering the GraphQL schema (see https://github.com/nikitastupin/clairvoyance for reverse-engineering the schema based on validation error suggestions).

Thus the best solution here is to actually create a separate plugin that does both, disabling introspection and hiding validation errors.

In terms of masking/hiding parse errors, I am not sure whether this is really needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants