Incompatible with cucumber 7.x.x

[mvtm-dn]

No description provided.

[davidjgoss]

@mvtm-dn is there anything I can do to help progress this?

[tongilcoto]

Yeah, I am stuck with this issue too

[mvtm-dn]

I apologize for the delay with the answer. I'm quite busy with my main work. But I hope I can solve this issue during CNY.

[lwiechec]

also looking forward to a fix! thanks

[mortelee]

also looking forward to a fix. Thanks in advance.

[silbe]

I've had a look at how to fix this. Because of the package rename from cucumber to @cucumber/cucumber some rather invasive changes are required and supporting both names is problematic in some places (e.g. package.json). My approach would be to create a branch for 0.2.x versions (in case we'd want to do a bug fix release for those), replace cucumber <= 6.x support in master with cucumber 7.x support and release a 0.3.0.

@mvtm-dn What do you think?

[mortelee]

I've re- implemented the junit-formatter, because Cucumber made some braking changes in v7:

• It is a mix of the json formatter, own ideas and the ideas of this project.
• typescript
• 100% unit test coverage
• no code duplication

Missing functionality in my version:

• No duration info in xml output. Could not get it to work while keeping 100% unit test coverage
  But with the opensource community I guess this is something we can fix together

The implementation I've created does not support Cucumber <v7.

Question is how you guys think about how we can make my implementation available to the community.
I see the following options:

• make a new major release that only supports Cucumber >= v7
• keep support for older versions in new major release
• create a new project that only supports Cucumber >= v7

@mvtm-dn @silbe What do you think?

[silbe]

I've re- implemented the junit-formatter, because Cucumber made some braking changes in v7:
[...]
Question is how you guys think about how we can make my implementation available to the community.
I see the following options:

* make a new major release that only supports Cucumber >= v7

* keep support for older versions in new major release

* create a new project that only supports Cucumber >= v7

@mvtm-dn @silbe What do you think?

Upstream decided to significantly tone down and delay the deprecation of the old "json" format (see MR cucumber-js#1650) so my customer will upgrade to cucumber-js 7.3.0 and stick with cucumber-junit for now instead of trying to get cucumber-junit-formatter to work. For this reason I've stopped working on the cucumber 7.x port.

Based on my experience trying to port cucumber-junit-formatter to cucumber v7 I agree that a reimplementation is a reasonable choice. At least the tests relied too much on API that was outright removed (without any explanation) and is not straightforward to replace.

Given that it's a new implementation by a new author, simply releasing it as a separate project is definitely an option. You could suggest replacing the link to cucumber-junit-formatter in the cucumber 7.x documentation with one to your project to the cucumber-js developers (e.g. by providing a merge request). Users of cucumber 6.x could continue using cucumber-junit-formatter, users of cucumber 7.x could use yours.

OTOH if @mvtm-dn is open to releasing your code in this repository there'd be a continuation of the name and users could simply upgrade to the new version of this package. Are the any other compatibility issues to look out for other than the duration?

[mortelee]

Are the any other compatibility issues to look out for other than the duration?

I'm not aware of any other compatibility issue at this moment.

[beradrian]

@mortelee where is your implementation available?

[maga-polito]

will there be a fix for this?