Apollo: Release source code for 51.8 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrespo
force-pushed
the
51.8-release-branch
branch
from
930df65
to
23f45fa
Compare
acrespo
force-pushed
the
51.8-release-branch
branch
from
23f45fa
to
12bff2b
Compare
champo
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[51.8] - 2024-02-23
CHANGED
the TLV onion as payment secret depends on it). Having the flag as optional was causing some strict
services to block zero amount invoices from Muun. If the secret is optional, the last hop (us) can
forward a fake sphinx without a payment secret and for 1 sat, the app will accept it since the
secret is optional and the last hop keeps the rest of the payment. Payment secret has been widely
adopted for quite a bit now. Major impls all require it.