Record DISCONNECT_WAIT in profile #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new profiling event called DISCONNECT_WAIT, which measures the time between the moment we close our ports, and the moment the corresponding ClosePort messages have been picked up by our peers and we can continue to shut down. Previously, the component showed as running during this time in the timeline plot, which is not correct, it's waiting.
The plotting code has been adapted to use it when available, and the database format version is incremented to 1.1. Version 1.0 databases remain supported, but will continue to give the old incorrect results.
This also adds a new example of a three-component dispatch chain, which produces nice test data, and fixes a bug with the timeline plot in case the database is small enough that we'll never have a data cutoff.
Addresses #254.