Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codetable): automatically include digest dep when needed #360

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

bishopcheckmate
Copy link
Contributor

Previously it was needed to manually enable the optional digest
dependency when using any of sha1,2,3, or ripemd features, and
it could only be found out via reading the sources or codetable
failed to build.

Also included some additional feature guards to clean up warnings
or errors that ocured when building without all features.

Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, that looks great! I've just left a minor comment about the version number.

codetable/Cargo.toml Outdated Show resolved Hide resolved
Previously it was needed to manually enable the optional digest
dependency when using any of sha1,2,3, or ripemd features, and
it could only be found out via reading the sources or codetable
failed to build.

Also included some additional feature guards to clean up warnings
or errors that ocured when building without all features.
@vmx vmx merged commit eeab02b into multiformats:master Jan 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants