Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RSA public key #226

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Add RSA public key #226

merged 1 commit into from
Sep 2, 2021

Conversation

expede
Copy link
Contributor

@expede expede commented Aug 29, 2021

Add RSA public key. Updated over #195

Changed from #195:

  • Move to 0x12XX range
  • Added X.509 directly to the name (happy to take out)

RSA is has length variants, I suppose that we're going to use multiformats to specify key length. Alternately, we could specify rsa-2048-pub, rsa-4096-pub, and so on, but it feels orthogonal to me.

Thoughts or changes @b5?

@b5
Copy link
Contributor

b5 commented Aug 29, 2021

nope looks good to me! I'll close the other PR in favour of this one

@expede
Copy link
Contributor Author

expede commented Aug 31, 2021

Oh, since this is a new PR, I should probably ping @rvagg 👋 No rush, just want to make sure that you'll see it!

@rvagg
Copy link
Member

rvagg commented Sep 2, 2021

This all seems good to me.

I'm not sure the lengths are orthogonal, but if, for practical purposes, you don't need that signalling up front when consuming the bytes then maybe it's unnecessary? If it turns out to be needed then we could easily add additional entries and maybe make this one a common length, 2048 perhaps. Or even rename it if we're not too far down that road. Will look to those who are using it to provide feedback on the utility of the length differentiation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants