fix: Rename webrtc-w3c to webrtc and webrtc to webrtc+sdp-munging #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following on from #150 and an replacement for #151 Renames: - `/webrtc-w3c` -> `/webrtc` - AKA browser to browser - `/webrtc` -> `/webrtc+sdp-munging` - AKA browser to server Discussion: - This option comes from comments on #151 - It got a lukewarm reception on the triage call so it's presented as an option along with #152 - Adding `+sdp-munging` makes it more explicit about the differences, though admittedly there are other differences that aren't encapsulated in the name - People were uncertain about universal understanding of the term "SDP munging"
thomaseizinger
approved these changes
Mar 15, 2023
| @@ -35,7 +35,7 @@ code, size, name, comment | |||
| 277, 0, p2p-stardust, | |||
| 275, 0, p2p-webrtc-star, | |||
| 276, 0, p2p-webrtc-direct, | |||
| 280, 0, webrtc, ICE-lite webrtc transport | |||
| 281, 0, webrtc-w3c, webrtc transport where connection establishment is according to w3c spec | |||
| 280, 0, webrtc+sdp-munging, ICE-lite webrtc transport with SDP munging during connection establishment and without use of a STUN server | |||
There was a problem hiding this comment.
Suggested change
| 280, 0, webrtc+sdp-munging, ICE-lite webrtc transport with SDP munging during connection establishment and without use of a STUN server | |
| 280, 0, webrtc-with-sdp-munging, ICE-lite webrtc transport with SDP munging during connection establishment and without use of a STUN server |
AFAIK, we don't need to save chars for performance reasons so this is perhaps a tad easier to understand?
|
Closing in favour of #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Following on from #150 and an replacement for #151
Renames:
/webrtc-w3c->/webrtc- AKA browser to browser/webrtc->/webrtc+sdp-munging- AKA browser to serverDiscussion:
+sdp-mungingmakes it more explicit about the differences, though admittedly there are other differences that aren't encapsulated in the nameBefore Merge