Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

fix: add CID validation #30

Merged
merged 2 commits into from
Mar 30, 2017
Merged

fix: add CID validation #30

merged 2 commits into from
Mar 30, 2017

Conversation

dignifiedquire
Copy link
Member

this also adds some api docs

@dignifiedquire
fix: add CID validation
2db64f4 
this also adds some api docs
daviddias
daviddias suggested changes Mar 30, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • improve err.msg
  • rm yarn.lock

src/index.js Outdated
*/
static validateCID (other) {
if (other == null) {
throw new Error('Nothing to see here')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a valuable error message

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a great error message 📦

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh common :)

@dignifiedquire dignifiedquire merged commit 38e5dd0 into master Mar 30, 2017
@dignifiedquire dignifiedquire deleted the fix/validation branch March 30, 2017 14:12
@dignifiedquire dignifiedquire removed the status/in-progress In progress label Mar 30, 2017
@dignifiedquire dignifiedquire mentioned this pull request Mar 30, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dignifiedquire @daviddias